Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23.3 Backport of #53286 - Bring back dns tests #296

Merged
merged 2 commits into from
Aug 15, 2023
Merged

23.3 Backport of #53286 - Bring back dns tests #296

merged 2 commits into from
Aug 15, 2023

Conversation

arthurpassos
Copy link
Collaborator

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Three tests were failing / flaky:

  1. test_host_regexp_multiple_ptr_records
  2. test_host_regexp_multiple_ptr_records_concurrent
  3. test_reverse_dns_query

Hard coding coredns version to 1.9.3 (latest version of coredns when these tests were introduced) fixed 1 and 2. The latter was failing because we relied on google dns, but that can fail sometimes. To fix this, I simply setup a DNS server for this test as well. It does not rely on 3rd party stuff anymore.

Backport ClickHouse#53286

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@altinity-robot
Copy link
Collaborator

altinity-robot commented Aug 12, 2023 •
edited
Loading

This is an automated comment for commit b0d1e48 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure

@Enmk Enmk changed the title Backport #53286 22.3 Backport of #53286 - Bring back **garbage** dns tests Aug 14, 2023
@Enmk Enmk changed the title 22.3 Backport of #53286 - Bring back **garbage** dns tests 23.3 Backport of #53286 - Bring back **garbage** dns tests Aug 14, 2023
@Enmk Enmk changed the title 23.3 Backport of #53286 - Bring back **garbage** dns tests 23.3 Backport of #53286 - Bring back dns tests Aug 15, 2023
@Enmk Enmk merged commit 7ed789a into customizations/23.3.8 Aug 15, 2023
45 of 50 checks passed
@Enmk Enmk mentioned this pull request Sep 25, 2023
Merged
@Enmk Enmk mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurpassos @altinity-robot @Enmk